Discussion:
respond inline to attached patch?
Xu Wang
2018-07-28 18:52:36 UTC
Permalink
Hello,

I sometime receive a message with an attached patch. I would like to
make a comment on a couple of lines in the patch. Is there easy way to
respond such that basically their attached patch is part of their
message so easier to make my comments in-line?

I can do this manually by opening the patch, pasting into mutt and
putting the ">" things. but I am hoping for even lazier :)

Kind regards,

Xu
Mihai Lazarescu
2018-07-29 00:16:06 UTC
Permalink
Post by Xu Wang
I sometime receive a message with an attached patch. I would like to
make a comment on a couple of lines in the patch. Is there easy way to
respond such that basically their attached patch is part of their
message so easier to make my comments in-line?
I do get text attachments included at the end of the quoted
message in replies, but I don't know exactly why. :-)

Maybe set honor_disposition = no:
http://www.mutt.org/doc/manual/#honor-disposition

Mihai
Xu Wang
2018-07-29 14:33:03 UTC
Permalink
Post by Xu Wang
I sometime receive a message with an attached patch. I would like to
make a comment on a couple of lines in the patch. Is there easy way to
respond such that basically their attached patch is part of their
message so easier to make my comments in-line?
I do get text attachments included at the end of the quoted message in
replies, but I don't know exactly why. :-)
http://www.mutt.org/doc/manual/#honor-disposition
Interesting, I didnt know about that. Changing it does not change for
me, but I found more information (that I should have been aware of
before, sorry). Mutt shows the following:

[-- Attachment #2: app2or_py.patch --]
[-- Type: text/x-patch; charset=UTF-8, Encoding: 7bit, Size: 4.2K --]

[-- text/x-patch is unsupported (use 'v' to view this part) --]

So now I just need to figure out how to make it supported. I wonder if
there is a way to make all "text/anything" supported.

Kind regards,

Xu
Mihai Lazarescu
2018-07-29 15:06:59 UTC
Permalink
Post by Xu Wang
[-- Attachment #2: app2or_py.patch --]
[-- Type: text/x-patch; charset=UTF-8, Encoding: 7bit, Size: 4.2K --]
[-- text/x-patch is unsupported (use 'v' to view this part) --]
So now I just need to figure out how to make it supported. I wonder if
there is a way to make all "text/anything" supported.
MIME type text/x-patch (and the lack of viewer) may be
the reason. What I get (mostly SVN commit reports) is type
text/plain:

Content-Disposition: attachment; filename=XXX.diff
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

You may be looking for a setting like:

auto_view text/x-patch

and specify a MIME handler for text/x-patch in .mailcap,
e.g., cat.

Mihai
Xu Wang
2018-07-29 15:25:47 UTC
Permalink
Post by Xu Wang
[-- Attachment #2: app2or_py.patch --]
[-- Type: text/x-patch; charset=UTF-8, Encoding: 7bit, Size: 4.2K --]
[-- text/x-patch is unsupported (use 'v' to view this part) --]
So now I just need to figure out how to make it supported. I wonder if
there is a way to make all "text/anything" supported.
MIME type text/x-patch (and the lack of viewer) may be the reason. What I
Content-Disposition: attachment; filename=XXX.diff
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
auto_view text/x-patch
and specify a MIME handler for text/x-patch in .mailcap, e.g., cat.
Mihai
Thank you! I will look into this. Thank you for helping.

Kind regards,

Xu

Loading...